-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: T3664: add support for building non-ISO flavors #550
Conversation
to be able to use its functions in build scripts
7d31ca4
to
a896176
Compare
Help should check if
Dependency
|
Unexpected flavor
|
It does nothing:
|
|
Signed-off-by: Daniil Baturin <daniil@vyos.io>
e4e8c03
to
7fa66c7
Compare
I can second this:
|
to avoid mistakenly listing auixilliary files like README as flavors
With |
and normalize it to a list if only one format is specified
Signed-off-by: Daniil Baturin <daniil@vyos.io>
to simplify the now-rather-tricky build script invocation
Signed-off-by: Daniil Baturin <daniil@vyos.io>
to avoid permission problems
Change Summary
Add support for building flavors other than ISO images directly from vyos-build.
The diff is, unfortunately, unavoidably messy-looking due to a large change, sorry about that.
Types of changes
Related Task(s)
Component(s) name
Build scripts.
Proposed changes
The following new fields are available in flavor files:
The build script supports the following new options:
--disk-size
— disk size in gigabytes (ignored for ISO)--reuse-iso
— path to an ISO image (relative tobuild/
), if given, the script will use it instead of building it from scratch.The script uses the following new environment variables:
VYOS_TEMPLATE_DIR
— normally should point to the template dir of thevyos-1x
submodule (the variable is passwd tovyos.template
). This variable is currently required for the script to work, we may want to find a way to add a hardcoded default to it so simplify script calls.VYOS_BUILD_FLAVORS_DIR
— optional variable to specify a separate dir with flavors (e.g., the new vyos-community-flavors repository),How to test
For example, put the following in
~/flavors/raw.toml
:You can download an nightly image to speed up things.
Then run something like this:
Checklist: